-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add npm ci #560
Merged
Merged
Feat/add npm ci #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
previously approved these changes
Oct 24, 2023
julien-devatom
requested review from
a team,
Rubilmax,
MerlinEgalite,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
October 25, 2023 06:57
Rubilmax
reviewed
Oct 25, 2023
Rubilmax
suggested changes
Oct 25, 2023
Just in case we ever publish ts: #561 |
Rubilmax
suggested changes
Oct 25, 2023
build(tsconfig): update to standard
Rubilmax
approved these changes
Oct 25, 2023
MerlinEgalite
approved these changes
Oct 25, 2023
Jean-Grimal
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Morpho blue does not have any dependency (forge or npm). We can use the contracts in both
hardhat
andfoundry
projects.If we want to ease Blue integrations to devs not working on Foundry, we can publish the package to npm.
However, publication to npm is a critical action that needs to have security about when and who can trigger the CI.
Solution