UtilsLib.zeroFloorSub is not utilised consistently
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MerlinEgalite
commented
Oct 23, 2023
MerlinEgalite
commented
- Fixes #https://github.com/cantinasec/review-morpho-blue-1/issues/58
MerlinEgalite
requested review from
Rubilmax,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
MerlinEgalite
commented
Oct 23, 2023
Rubilmax
reviewed
Oct 23, 2023
Rubilmax
reviewed
Oct 23, 2023
Jean-Grimal
approved these changes
Oct 23, 2023
QGarchery
requested changes
Oct 24, 2023
MerlinEgalite
changed the title
zeroFloorSub after toAssetsUpUtilsLib.zeroFloorSub is not utilised consistently
Rubilmax
previously approved these changes
Oct 25, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
MerlinEgalite
dismissed stale reviews from Rubilmax and Jean-Grimal
via
740d37f
Jean-Grimal
previously approved these changes
Oct 25, 2023
Closed
QGarchery
previously approved these changes
Oct 26, 2023
MerlinEgalite
commented
Oct 26, 2023
Signed-off-by: Merlin Egalite <[email protected]>
MerlinEgalite
dismissed stale reviews from QGarchery and Jean-Grimal
via
a937fb0
Rubilmax
previously approved these changes
Oct 26, 2023
QGarchery
previously approved these changes
Oct 26, 2023
MathisGD
reviewed
Nov 2, 2023
Jean-Grimal
previously approved these changes
Nov 2, 2023
|
I think we should merge as is |
MathisGD
reviewed
Nov 8, 2023
Signed-off-by: MathisGD <[email protected]>
MathisGD
approved these changes
Nov 8, 2023
QGarchery
approved these changes
Nov 8, 2023
Rubilmax
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.