Add name in EIP712 domain #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
Rubilmax,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
Rubilmax
approved these changes
Oct 18, 2023
Jean-Grimal
approved these changes
Oct 18, 2023
MathisGD
requested changes
Oct 18, 2023
How is it dangerous? The chain id and the verifying contract's address is hashed into the domain, so it's only a matter of UI? |
|
Ah right, fair point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cantinasec/review-morpho-blue-1/issues/38
Why we did not include it:
#425
To be discussed.