Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIF naming #506

Merged
merged 1 commit into from
Sep 25, 2023
Merged

LIF naming #506

merged 1 commit into from
Sep 25, 2023

Conversation

MathisGD
Copy link
Contributor

@MathisGD MathisGD commented Sep 21, 2023 •
edited
Loading

@MathisGD MathisGD marked this pull request as ready for review September 22, 2023 15:24
@MathisGD MathisGD requested review from QGarchery, a team, Rubilmax, MerlinEgalite and Jean-Grimal and removed request for a team September 22, 2023 15:25
@MathisGD MathisGD self-assigned this Sep 22, 2023
Jean-Grimal
Jean-Grimal reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer incentiveFactor, because it is already implicit that it is related to liquidation

@MerlinEgalite
Copy link
Contributor

I think I prefer incentiveFactor, because it is already implicit that it is related to liquidation

I agree with Jean. It adds verbosity for no clear with no clear upsides ...

@MathisGD
Copy link
Contributor Author

The goal is to be consistent with the papers, where it's probably better to use liquidation incentive factor (right?)

MerlinEgalite
MerlinEgalite approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge it after #493 since it has not been reviewed by OZ?

@MerlinEgalite MerlinEgalite merged commit de117aa into main Sep 25, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the style/liquidation-incentives-factor branch September 25, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MathisGD @MerlinEgalite @Rubilmax @QGarchery @Jean-Grimal