Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L-09 Rounding Error Might Prevent Borrowing at the Maximum Limit #489

Merged
merged 3 commits into from
Sep 22, 2023
Merged

L-09 Rounding Error Might Prevent Borrowing at the Maximum Limit #489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21d4a32
docs: acknowledge isHealthy roundings
MerlinEgalite Sep 15, 2023
c1411e4
docs: simplify comment
MerlinEgalite Sep 16, 2023
465cb7f
docs: apply suggestion
MerlinEgalite Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Morpho.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,9 @@ contract Morpho is IMorpho {
}

/// @dev Returns whether the position of `borrower` in the given market `marketParams` with the given
/// `collateralPrice`
/// is healthy.
/// `collateralPrice` is healthy.
/// @dev Assumes that the inputs `marketParams` and `id` match.
/// @dev Rounds in favor of the protocol, so one might not be able to borrow exactly `maxBorrow` but one unit less.
function _isHealthy(MarketParams memory marketParams, Id id, address borrower, uint256 collateralPrice)
internal
view
Expand Down