Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(hardhat): revert to old tests #463

Merged
merged 4 commits into from
Sep 15, 2023
Merged

test(hardhat): revert to old tests #463

merged 4 commits into from
Sep 15, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Sep 1, 2023

There are 2 issues to me with the current hardhat tests:

  1. they never call the IRM (so gas cost is under-estimated)
  2. every signer both supplies and borrows from the market, which is problematic because packed storage slots may be initialized for borrowers whereas they wouldn't in practice (so gas cost is under-estimated)

With the current storage layout, claim 2 is not applicable

@Rubilmax

This comment was marked as outdated.

@Rubilmax Rubilmax requested review from a team, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery, peyha and MathisGD and removed request for a team September 1, 2023 12:32
@Rubilmax Rubilmax marked this pull request as ready for review September 1, 2023 12:32
@Rubilmax Rubilmax marked this pull request as draft September 1, 2023 12:35
@Rubilmax Rubilmax marked this pull request as ready for review September 1, 2023 12:37
MerlinEgalite
MerlinEgalite previously approved these changes Sep 1, 2023
@Rubilmax Rubilmax merged commit 0847212 into main Sep 15, 2023
4 checks passed
@Rubilmax Rubilmax deleted the refactor/hardhat-tests branch September 15, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants