Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pragma): update solidity pragmas #426

Merged
merged 1 commit into from
Aug 23, 2023
Merged

refactor(pragma): update solidity pragmas #426

merged 1 commit into from
Aug 23, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Aug 23, 2023 •
edited
Loading

@Rubilmax Rubilmax requested review from a team, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery, peyha and MathisGD and removed request for a team August 23, 2023 14:32
@Rubilmax Rubilmax marked this pull request as ready for review August 23, 2023 14:32
MathisGD
MathisGD approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 0.8.8 is for user defined types
  • 0.8.12 is for encodeCall and using the function name
  • 0.6.12 is for interfaces importing interfaces (not mandatory but why not)

I think that we could put ^0.8.0 also for interfaces, no one is still using 0.7 and below

@MerlinEgalite MerlinEgalite merged commit 9c7d527 into main Aug 23, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/solidity-pragma branch August 23, 2023 15:47
This was referenced Sep 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD MathisGD approved these changes

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal Jean-Grimal was automatically assigned from morpho-labs/onchain

@QGarchery QGarchery Awaiting requested review from QGarchery QGarchery was automatically assigned from morpho-labs/protocol

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solidity pragma constraints may not be well suited in all files
5 participants
@Rubilmax @MerlinEgalite @pakim249CAL @MathisGD @makcandrov