docs(oracle): update natspecs #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
a team,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery,
peyha and
MathisGD
and removed request for
a team
|
wait I don't think that this is true. Aren't we quoting 1 wei of the collateral asset in 1 wei of the borrowable asset (so non dependent on the number of decimals) ? |
Jean-Grimal
previously approved these changes
Aug 23, 2023
MathisGD
reviewed
Aug 23, 2023
MathisGD
reviewed
Aug 23, 2023
Rubilmax
force-pushed
the
refactor/natspecs
branch
from
6c65f41
to
24e2eff
Compare
MathisGD
previously approved these changes
Aug 23, 2023
MerlinEgalite
previously approved these changes
Aug 23, 2023
QGarchery
requested changes
Aug 23, 2023
MathisGD
approved these changes
Aug 23, 2023
pakim249CAL
approved these changes
Aug 23, 2023
QGarchery
approved these changes
Aug 23, 2023
MerlinEgalite
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which highlights an additional requirement on the borrowable token: it must have less than 36 + collateral decimals @QGarchery