Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add license #420

Merged
merged 9 commits into from
Aug 28, 2023
Merged

feat: add license #420

merged 9 commits into from
Aug 28, 2023

Conversation

PaulFrambot
Copy link
Contributor

@PaulFrambot PaulFrambot requested review from julien-devatom and a team August 23, 2023 06:36
@PaulFrambot PaulFrambot self-assigned this Aug 23, 2023
julien-devatom
julien-devatom previously approved these changes Aug 23, 2023
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update all files

MerlinEgalite
MerlinEgalite previously approved these changes Aug 23, 2023
Rubilmax
Rubilmax previously approved these changes Aug 23, 2023
makcandrov
makcandrov previously approved these changes Aug 23, 2023
@QGarchery QGarchery linked an issue Aug 23, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many files with the UNLICENSED keyword still. Those are test files and in the src/mocks folder too. Should they be GPL2 or MIT ?

@MerlinEgalite
Copy link
Contributor

There are many files with the UNLICENSED keyword still. Those are test files and in the src/mocks folder too. Should they be GPL2 or MIT ?

I intentionally left them as UNLICENSED as it's does not really make sense to set a specific license to mock or test files IMO but I'm ok to change if you feel we should do it.

@QGarchery
Copy link
Contributor

Yes I think it should be changed, it feels like it is an oversight otherwise and it's better if the rules are clear

@MathisGD
Copy link
Contributor

MathisGD commented Aug 23, 2023

I think that legally something unlicensed is equivalents to the most permissive ones, so why not just put that ?

Edit: no it is not, so we want something more permissive, just in case someone needs them for production use in some ways

julien-devatom
julien-devatom previously approved these changes Aug 23, 2023
package.json Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
src/interfaces/LICENSE Show resolved Hide resolved
src/interfaces/LICENSE Outdated Show resolved Hide resolved
LICENSE Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Merlin Egalite <[email protected]>
@MerlinEgalite MerlinEgalite merged commit e124f5d into main Aug 28, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the feat/add-license branch August 28, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License
8 participants