Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document external contracts requirements #414

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Document external contracts requirements #414

merged 8 commits into from
Aug 25, 2023

Conversation

MathisGD
Copy link
Contributor

Fixes #125

@MathisGD MathisGD requested review from a team August 22, 2023 11:42
@MathisGD MathisGD self-assigned this Aug 22, 2023
@MathisGD MathisGD requested review from Rubilmax, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery and peyha and removed request for a team August 22, 2023 11:42
Rubilmax
Rubilmax previously approved these changes Aug 22, 2023
View reviewed changes
MathisGD
MathisGD commented Aug 22, 2023
View reviewed changes
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Aug 22, 2023
View reviewed changes
MerlinEgalite
MerlinEgalite requested changes Aug 22, 2023
View reviewed changes
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
@MerlinEgalite
docs: fix typo
ef72847 
Signed-off-by: Merlin Egalite <[email protected]>
MerlinEgalite
MerlinEgalite previously approved these changes Aug 22, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Aug 22, 2023
View reviewed changes
QGarchery
QGarchery reviewed Aug 22, 2023
View reviewed changes
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
QGarchery
QGarchery approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes but it sounds good now 🎉

src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
QGarchery
QGarchery requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's missing the requirement on the total supply of the token. This one is easy to check and the limit could very well be reached depending on what new tokens decide to use for their decimals

@MathisGD MathisGD linked an issue Aug 23, 2023 that may be closed by this pull request
Document the risks of external contracts freezing the market #402
Closed
5 tasks
@MathisGD
Copy link
Contributor Author

Actually it's missing the requirement on the total supply of the token. This one is easy to check and the limit could very well be reached depending on what new tokens decide to use for their decimals

isn't this enough https://github.com/morpho-labs/morpho-blue/blob/47a06190760c8ae321cc6116bcd8f38afbcc0b61/src/interfaces/IMorpho.sol#L123

@QGarchery
Copy link
Contributor

I don't think it's enough because the requirement is needed for every computation, not just when entering a position. For example, it can happen that interest accumulated make so that the amount that you are owed increases and that now the funds are stuck. Another example is if the total amount changes, and now the bigger positions revert but not smaller ones

MerlinEgalite
MerlinEgalite previously approved these changes Aug 25, 2023
View reviewed changes
QGarchery
QGarchery previously approved these changes Aug 25, 2023
View reviewed changes
Rubilmax
Rubilmax reviewed Aug 25, 2023
View reviewed changes
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Aug 25, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Aug 25, 2023
View reviewed changes
@MathisGD @Rubilmax
docs: minor improvements
f01e08b 
Co-authored-by: Romain Milon <[email protected]>
Signed-off-by: MathisGD <[email protected]>
@MathisGD MathisGD merged commit cd1e467 into main Aug 25, 2023
4 checks passed
@MathisGD MathisGD deleted the docs/external-contracts-requirements branch August 25, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@makcandrov makcandrov Awaiting requested review from makcandrov makcandrov was automatically assigned from morpho-labs/onchain

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

@Rubilmax Rubilmax Awaiting requested review from Rubilmax

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@MathisGD @QGarchery @Rubilmax @MerlinEgalite @pakim249CAL @Jean-Grimal