MarketParams naming #412
Merged
MarketParams naming #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MathisGD <[email protected]>
MathisGD
requested review from
a team,
Rubilmax,
MerlinEgalite,
pakim249CAL,
Jean-Grimal and
makcandrov
and removed request for
a team
MathisGD
requested review from
QGarchery and
peyha
and removed request for
a team
makcandrov
previously approved these changes
Aug 22, 2023
Signed-off-by: MathisGD <[email protected]>
makcandrov
previously approved these changes
Aug 22, 2023
|
Trust me tests are passing, it's a cache issue but I don't know how to delete it I can't find it. |
need to merge with main I think |
MerlinEgalite
previously approved these changes
Aug 22, 2023
|
Conflicts to resolve |
MathisGD
dismissed stale reviews from MerlinEgalite and makcandrov
via
ab875a3
Jean-Grimal
approved these changes
Aug 22, 2023
makcandrov
approved these changes
Aug 22, 2023
pakim249CAL
approved these changes
Aug 22, 2023
Rubilmax
reviewed
Aug 22, 2023
Rubilmax
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404 and adapt naming in tests