Document idToMarketParams
#411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MathisGD <[email protected]>
MathisGD
requested review from
Rubilmax,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery and
peyha
and removed request for
a team
Rubilmax
previously approved these changes
Aug 22, 2023
QGarchery
previously approved these changes
Aug 22, 2023
pakim249CAL
previously approved these changes
Aug 22, 2023
Jean-Grimal
previously approved these changes
Aug 22, 2023
Signed-off-by: MathisGD <[email protected]>
MathisGD
dismissed stale reviews from Jean-Grimal, pakim249CAL, QGarchery, and Rubilmax
via
a151a0f
MathisGD
requested review from
Rubilmax,
pakim249CAL,
Jean-Grimal and
QGarchery
Rubilmax
previously approved these changes
Aug 22, 2023
makcandrov
reviewed
Aug 22, 2023
Co-authored-by: makcandrov <[email protected]> Signed-off-by: MathisGD <[email protected]>
makcandrov
approved these changes
Aug 22, 2023
Rubilmax
approved these changes
Aug 22, 2023
pakim249CAL
approved these changes
Aug 22, 2023
QGarchery
approved these changes
Aug 22, 2023
Comment on lines
+87
to
+88
| /// @dev This mapping is not used in Morpho. It is there to enable reducing the cost associated to calldata on layer | ||
| /// 2s by creating a wrapper contract with functions that take `id` as input instead of `marketParams`. |
There was a problem hiding this comment.
Really infortunate line-splitting (ok I promise it's the last time I make this kind of comment)
There was a problem hiding this comment.
Unresolving this so that everyone can see that I agree with you @QGarchery and this is one of the ugliest thing I've seen on earth
MerlinEgalite
approved these changes
Aug 22, 2023
Comment on lines
+87
to
+88
| /// @dev This mapping is not used in Morpho. It is there to enable reducing the cost associated to calldata on layer | ||
| /// 2s by creating a wrapper contract with functions that take `id` as input instead of `marketParams`. |
There was a problem hiding this comment.
Unresolving this so that everyone can see that I agree with you @QGarchery and this is one of the ugliest thing I've seen on earth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400