Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MorphoLib perf and test #384

Merged
merged 4 commits into from
Aug 20, 2023
Merged

MorphoLib perf and test #384

merged 4 commits into from
Aug 20, 2023

Conversation

MathisGD
Copy link
Contributor

@MathisGD MathisGD commented Aug 20, 2023 •
edited
Loading

perf: use extSload in MorphoLib to avoid loading the whole Market struct from storage

Fixes #375

Fixes #383

@MathisGD MathisGD self-assigned this Aug 20, 2023
@MathisGD MathisGD changed the title Perf MorphoLib MorphoLib perf and test Aug 20, 2023
@MathisGD MathisGD requested review from a team, Rubilmax, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery and peyha and removed request for a team August 20, 2023 09:55
@MathisGD MathisGD marked this pull request as ready for review August 20, 2023 09:56
QGarchery
QGarchery previously approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of optional changes

src/libraries/periphery/MorphoLib.sol Outdated Show resolved Hide resolved
test/forge/periphery/MorphoLib.t.sol Show resolved Hide resolved
MerlinEgalite
MerlinEgalite previously approved these changes Aug 20, 2023
View reviewed changes
src/libraries/periphery/MorphoLib.sol Show resolved Hide resolved
@MathisGD MathisGD merged commit 6a733ad into main Aug 20, 2023
4 checks passed
@MathisGD MathisGD deleted the feat/375 branch August 20, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax Rubilmax was automatically assigned from morpho-labs/onchain

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal Jean-Grimal was automatically assigned from morpho-labs/onchain

@makcandrov makcandrov Awaiting requested review from makcandrov makcandrov was automatically assigned from morpho-labs/onchain

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MorphoLib is not tested Create simple market getters without loading the whole market in memory
4 participants
@MathisGD @QGarchery @MerlinEgalite @pakim249CAL