Add warning on repay/withdraw #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
Rubilmax,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery,
peyha and
MathisGD
and removed request for
a team
MathisGD
reviewed
Aug 12, 2023
MathisGD
reviewed
Aug 12, 2023
MathisGD
reviewed
Aug 12, 2023
MathisGD
previously approved these changes
Aug 12, 2023
pakim249CAL
previously approved these changes
Aug 12, 2023
Rubilmax
reviewed
Aug 12, 2023
Jean-Grimal
previously approved these changes
Aug 13, 2023
MerlinEgalite
dismissed stale reviews from Jean-Grimal, pakim249CAL, and MathisGD
via
878f7c2
MerlinEgalite
requested review from
Rubilmax,
MathisGD,
pakim249CAL and
Jean-Grimal
pakim249CAL
approved these changes
Aug 13, 2023
Jean-Grimal
approved these changes
Aug 13, 2023
MathisGD
approved these changes
Aug 13, 2023
Rubilmax
reviewed
Aug 13, 2023
| @@ -142,6 +144,7 @@ interface IMorpho is IFlashLender { | |||
| /// but the possibility to burn a specific amount of shares is given | |||
| /// for full compatibility and precision. | |||
| /// @dev `msg.sender` must be authorized to manage `onBehalf`'s positions. | |||
| /// @dev Borrowing a large amount can underflow and revert without any error message. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
IMO adding comments on other inputs does not bring value to the integrators