refactor: homogenize IBlue with Blue naming
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-devatom
requested review from
Rubilmax,
QGarchery,
MerlinEgalite,
pakim249CAL and
MathisGD
MerlinEgalite
approved these changes
Aug 8, 2023
makcandrov
approved these changes
Aug 8, 2023
Rubilmax
approved these changes
Aug 8, 2023
| @@ -115,7 +115,7 @@ interface IBlue is IFlashLender { | |||
| function liquidate(Market memory market, address borrower, uint256 seized, bytes memory data) external; | |||
| function flashLoan(address token, uint256 amount, bytes calldata data) external; | |||
|
|
|||
| function setAuthorization(address manager, bool isAllowed) external; | |||
| function setAuthorization(address authorized, bool newIsAuthorized) external; | |||
There was a problem hiding this comment.
Suggested change
| function setAuthorization(address authorized, bool newIsAuthorized) external; | |
| function setAuthorization(address authorized, bool isAuthorized) external; |
There was a problem hiding this comment.
It's not exactly the same naming than in Blue though so i'd be against
MathisGD
approved these changes
Aug 8, 2023
pakim249CAL
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
IBluehas an outdated naming forsetAuthorization