refactor: make createMarket more straightforward
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makcandrov
requested review from
Rubilmax,
MerlinEgalite,
pakim249CAL,
MathisGD and
Jean-Grimal
Jean-Grimal
previously approved these changes
Aug 3, 2023
Rubilmax
previously approved these changes
Aug 3, 2023
MerlinEgalite
previously approved these changes
Aug 3, 2023
MathisGD
reviewed
Aug 3, 2023
pakim249CAL
previously approved these changes
Aug 3, 2023
makcandrov
dismissed stale reviews from pakim249CAL, MerlinEgalite, Rubilmax, and Jean-Grimal
via
aef4c0c
Rubilmax
approved these changes
Aug 3, 2023
|
Like that it makes more sense to emit the event after the storage update, I guess, to be consistent with other only owner functions |
makcandrov
requested review from
MathisGD,
pakim249CAL,
MerlinEgalite and
Jean-Grimal
Jean-Grimal
approved these changes
Aug 3, 2023
pakim249CAL
approved these changes
Aug 4, 2023
MathisGD
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here I directly created the PR so that we can continue this discussion