Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nitpick) nitpick #116

Merged
merged 2 commits into from
Dec 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/AdaptiveCurveIrm.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ contract AdaptiveCurveIrm is IAdaptiveCurveIrm {
using MathLib for int256;
using UtilsLib for int256;
using MorphoMathLib for uint128;
using MorphoMathLib for uint256;
using MarketParamsLib for MarketParams;

/* EVENTS */
Expand Down Expand Up @@ -95,7 +94,7 @@ contract AdaptiveCurveIrm is IAdaptiveCurveIrm {
endRateAtTarget = ConstantsLib.INITIAL_RATE_AT_TARGET;
} else {
// The speed is assumed constant between two updates, but it is in fact not constant because of interest.
// So the rate will be underestimated.
// So the rate is always underestimated.
int256 speed = ConstantsLib.ADJUSTMENT_SPEED.wMulToZero(err);
// market.lastUpdate != 0 because it is not the first interaction with this market.
// Safe "unchecked" cast because block.timestamp - market.lastUpdate <= block.timestamp <= type(int256).max.
Expand Down