docs(fee): add acknowledegement #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rubilmax
commented
Dec 12, 2023
Rubilmax
commented
- Fixes https://cantina.xyz/code/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/dc29a0e6-64b1-4f9b-a73e-9ce28b7f34a4
Rubilmax
requested review from
adhusson,
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
Jean-Grimal
approved these changes
Dec 12, 2023
MerlinEgalite
approved these changes
Dec 12, 2023
adhusson
approved these changes
Dec 18, 2023
Merged
StErMi
reviewed
Dec 30, 2023
| @@ -916,6 +916,7 @@ contract MetaMorpho is ERC4626, ERC20Permit, Ownable2Step, Multicall, IMetaMorph | |||
|
|
|||
| uint256 totalInterest = newTotalAssets.zeroFloorSub(lastTotalAssets); | |||
| if (totalInterest != 0 && fee != 0) { | |||
| // It is acknowledged that `feeAssets` may be rounded down to 0 if `totalInterest * fee < WAD`. | |||
There was a problem hiding this comment.
Should it also (or moved) documented in the function's natspec as well with a warning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.