Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mnemonic-indexes parameter to README #24

Merged
merged 1 commit into from
May 22, 2023
Merged

Add mnemonic-indexes parameter to README #24

merged 1 commit into from
May 22, 2023

Conversation

Rubilmax
Copy link
Collaborator

No description provided.

@Rubilmax Rubilmax marked this pull request as ready for review May 22, 2023 08:56
julien-devatom
julien-devatom requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@julien-devatom julien-devatom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to retrieve the address used before signing?

README.md Outdated Show resolved Hide resolved
@Rubilmax
Copy link
Collaborator Author

Rubilmax commented May 22, 2023 •
edited
Loading

Is there a way to retrieve the address used before signing?

There could be, using cast wallet address, but it would require to interact twice with the HW or console, which is cumbersome. The only way would be to have it implemented in cast directly
(There's not even any debug messages logged)

MerlinEgalite
MerlinEgalite approved these changes May 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Rubilmax Rubilmax force-pushed the docs/readme-mnemonic-indexes branch from 05b8a97 to c1e9646 Compare May 22, 2023 14:27
@Rubilmax Rubilmax force-pushed the docs/readme-mnemonic-indexes branch from c1e9646 to 8c0df6e Compare May 22, 2023 14:42
@julien-devatom julien-devatom merged commit 9cee3cd into main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-devatom julien-devatom julien-devatom approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Tristan22400 Tristan22400 Awaiting requested review from Tristan22400

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

@MathisGD MathisGD Awaiting requested review from MathisGD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rubilmax @MerlinEgalite @julien-devatom