Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only append signature to file if no error #22

Merged
merged 4 commits into from
May 16, 2023
Merged

Only append signature to file if no error #22

merged 4 commits into from
May 16, 2023

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented May 15, 2023

Fixes #18

@Rubilmax Rubilmax linked an issue May 15, 2023 that may be closed by this pull request
@Rubilmax Rubilmax marked this pull request as ready for review May 16, 2023 09:01
@Rubilmax Rubilmax linked an issue May 16, 2023 that may be closed by this pull request
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@julien-devatom julien-devatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner ahah

🚀 🔥 LGTM 🔥 🚀

Base automatically changed from fix/hash-on-sign to main May 16, 2023 15:03
@Rubilmax Rubilmax merged commit 699e2ec into main May 16, 2023
@Rubilmax Rubilmax deleted the fix/sign-error branch May 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with SAFE_NONCE Errors are dumped in the signatures.txt file
5 participants