Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always hash when signing #21

Merged
merged 3 commits into from
May 16, 2023
Merged

Always hash when signing #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
309c7b9
fix(sign): always hash when signing
Rubilmax May 15, 2023
4a25d72
fix(sign): only append signature to file if no error
Rubilmax May 15, 2023
4b674bf
Merge branch 'feat/multisend' of github.com:morpho-labs/safer into fi…
Rubilmax May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ tx:
hash:
forge script script/HashData.s.sol

sign\:%:
cast wallet sign --$* $$(cat data/hashData.txt) >> data/signatures.txt
sign\:%: hash
Rubilmax marked this conversation as resolved.
Show resolved Hide resolved
OUTPUT=$$(cast wallet sign --$* $$(cat data/hashData.txt)) && if [[ "$$OUTPUT" =~ "^0x" ]]; then $$OUTPUT >> data/signatures.txt; fi

simulate\:%:
forge script script/ExecTransaction.s.sol --$*
Expand All @@ -25,9 +25,10 @@ exec\:%:
forge script script/ExecTransaction.s.sol --$* --broadcast

clean:
mkdir -p data
cp data/template.json data/tx.json
> data/hashData.txt
> data/signatures.txt


.PHONY: contracts test coverage
.PHONY: contracts test coverage hash sign simulate exec clean