-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AvistaZ and CinemaZ subtitles provider (via web scraping) #2375
Introduce AvistaZ and CinemaZ subtitles provider (via web scraping) #2375
Conversation
…chived subs downloading
@morpheus65535 I feel there should be some kind of rate limiter or a debounce to limit requests to the tracker so users won't get flagged or banned because of an excessive load. I'm not really a Python dev, so I have no idea how to approach it better. Would appreciate some thoughts on this. |
The only way to achieve that is by using time.sleep() to slow down the process. If it was an API with rate-limite headers, it would be cleaner but I'm pretty sure it's not the case here. Other than that, I don't see anything that offend me. It seems to be good work. Please, just bring all the imports at the beginning. |
@morpheus65535 thanks for the review |
How does this works with legacy API from older Sonarr versions? We still try to connect to Sonarr prior to v3. We could completely stop supporting it but it will require to rework some stuff if we want to do it. |
I couldn't find API docs for pre v3 Sonarr, but I looked through Sonarr v2 source code and looks like it should be working fine. The |
… don't throttle the provider
…t in release title, but not in file names
@goroskob hi can you write a better explanation on how to fill the cookie data. For my script I was just pointing to the cookie file but with this I am not sure how to fill. |
@Dnkhatri hey! You are supposed to put string representation of your cookies in there. It's in the format of |
was anyone apart from the dev able to get this to work. As Ii was not able to so gave it up. The instruction for how to use the cookie are not clear for me. |
@Dnkhatri sorry for the inconvenience. I haven't realized more detailed instructions are needed, since it's almost the same as already existing Addic7ed provider. Here is a step-by-step on how to get your cookies in Google Chrome:
Now the cookies in the correct format are copied into your clipboard. You just paste them into Cookies field in Bazarr provider's settings |
@goroskob Hi I followed you instruction and installed the plugin but I get this error when I search |
Dnkhatri what Python version are you running Bazarr on? I have found a similar issue here on GitHub, which was fixed by upgrading from Python 3.6.9 to 3.8.2 |
its the default python install on linux mint Python 3.10.12 |
@goroskob @morpheus65535 |
@Dnkhatri what is the output of pip list? |
This is the output
|
@Dnkhatri You have Brotli installed. Requests module will use it if it's available. If not, it will make sure that response aren't encoded with Brotli. I would highly suggest that you use a venv to run Bazarr either only the requirements installed. |
Was able to get it to work at last. Works great though it ads HI for hearing impaired in the filename I don't want that now need to know how to fix that. |
It's because Bazarr discovered hearing-impaired content in the subtitles file. You can use another extension for HI file (in Settings-->Subtitles) but you can't disable this (or it must be done at your own risk using a custom post-processing script which may cause download or upgrade loop). |
WIth asian content a lot of written text is shown in brackets which prowlarr wrongly detects has HI. I already was using custom script to do some modifications just added renaming to it as well. Working so far. Avistaz has no hearing impaired subs as far as I know would it be possible for prowlarr to ignore subs from avistaz for marking as HI. |
No need to be getting people to install extensions: See: https://github.com/Jackett/Jackett/wiki/Finding-cookies |
Hello I get this error when searching for subtitles
|
This PR introduces a new subscription provider for AvistaZ and CinemaZ torrent trackers.
The provider uses a subtitles search page and scrapes all the data and download links from there.refine_from_arr_history
refiner queries Sonarr/Radarr's/history
endpoint for grabs of the video and extracts it's Info URL, from which subtitles are fetched byAvistazProvider
/CinemazProvider
avistaz
orcinemaz
providers are present in settingsThe implementation can easily be extended extended to work on AvistaZ/CinemaZ sister tracker PrivateHD. I don't have invite there however.