GetMockForAbstractClass

See: sebastianbergmann/phpunit#5241
morozov · Jun 13, 2023 · f933619 · f933619
1 parent b66c59a
commit f933619
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 39 deletions.
diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -530,7 +530,7 @@ public function testPlatformDetectionFetchedFromParameters(): void
 
         $driverConnectionMock = $this->createMock(Driver\Connection::class);
 
-        $platformMock = $this->getMockForAbstractClass(AbstractPlatform::class);
+        $platformMock = $this->createMock(AbstractPlatform::class);
 
         $connection = new Connection(['serverVersion' => '8.0'], $driverMock);
 
@@ -552,7 +552,7 @@ public function testPlatformDetectionFetchedFromPrimaryReplicaParameters(): void
 
         $driverConnectionMock = $this->createMock(Driver\Connection::class);
 
-        $platformMock = $this->getMockForAbstractClass(AbstractPlatform::class);
+        $platformMock = $this->createMock(AbstractPlatform::class);
 
         $connection = new Connection(['primary' => ['serverVersion' => '8.0']], $driverMock);
 

diff --git a/tests/Functional/Ticket/DBAL461Test.php b/tests/Functional/Ticket/DBAL461Test.php
@@ -17,7 +17,7 @@ class DBAL461Test extends TestCase
     public function testIssue(): void
     {
         $conn     = $this->createMock(Connection::class);
-        $platform = $this->getMockForAbstractClass(SQLServerPlatform::class);
+        $platform = new SQLServerPlatform();
         $platform->registerDoctrineTypeMapping('numeric', Types::DECIMAL);
 
         $schemaManager = new SQLServerSchemaManager($conn, $platform);

diff --git a/tests/Types/BaseDateTypeTestCase.php b/tests/Types/BaseDateTypeTestCase.php
@@ -26,7 +26,7 @@ abstract class BaseDateTypeTestCase extends TestCase
 
     protected function setUp(): void
     {
-        $this->platform        = $this->getMockForAbstractClass(AbstractPlatform::class);
+        $this->platform        = $this->createMock(AbstractPlatform::class);
         $this->currentTimezone = date_default_timezone_get();
     }
 

diff --git a/tests/Types/BinaryTest.php b/tests/Types/BinaryTest.php
@@ -35,39 +35,6 @@ public function testReturnsBindingType(): void
         self::assertSame(ParameterType::BINARY, $this->type->getBindingType());
     }
 
-    /**
-     * @param mixed[][] $definition
-     *
-     * @dataProvider definitionProvider()
-     */
-    public function testReturnsSQLDeclaration(array $definition, string $expectedDeclaration): void
-    {
-        $platform = $this->getMockForAbstractClass(AbstractPlatform::class);
-        self::assertSame($expectedDeclaration, $this->type->getSQLDeclaration($definition, $platform));
-    }
-
-    /** @return mixed[][] */
-    public static function definitionProvider(): iterable
-    {
-        return [
-            'fixed-unspecified-length' => [
-                ['fixed' => true],
-                'BINARY',
-            ],
-            'fixed-specified-length' => [
-                [
-                    'fixed' => true,
-                    'length' => 20,
-                ],
-                'BINARY(20)',
-            ],
-            'variable-length' => [
-                ['length' => 20],
-                'VARBINARY(20)',
-            ],
-        ];
-    }
-
     public function testBinaryNullConvertsToPHPValue(): void
     {
         self::assertNull($this->type->convertToPHPValue(null, $this->platform));

diff --git a/tests/Types/DateTest.php b/tests/Types/DateTest.php
@@ -17,6 +17,9 @@ protected function setUp(): void
         $this->type = new DateType();
 
         parent::setUp();
+
+        $this->platform->method('getDateFormatString')
+            ->willReturn('Y-m-d');
     }
 
     public function testDateConvertsToPHPValue(): void

diff --git a/tests/Types/DateTimeTest.php b/tests/Types/DateTimeTest.php
@@ -15,13 +15,16 @@ protected function setUp(): void
         $this->type = new DateTimeType();
 
         parent::setUp();
+
+        $this->platform->method('getDateTimeFormatString')
+            ->willReturn('Y-m-d H:i:s');
     }
 
     public function testDateTimeConvertsToDatabaseValue(): void
     {
         $date = new DateTime('1985-09-01 10:10:10');
 
-        $expected = $date->format($this->platform->getDateTimeTzFormatString());
+        $expected = $date->format($this->platform->getDateTimeFormatString());
         $actual   = $this->type->convertToDatabaseValue($date, $this->platform);
 
         self::assertEquals($expected, $actual);

diff --git a/tests/Types/DateTimeTzTest.php b/tests/Types/DateTimeTzTest.php
@@ -15,6 +15,9 @@ protected function setUp(): void
         $this->type = new DateTimeTzType();
 
         parent::setUp();
+
+        $this->platform->method('getDateTimeTzFormatString')
+            ->willReturn('Y-m-d H:i:s');
     }
 
     public function testDateTimeConvertsToDatabaseValue(): void

diff --git a/tests/Types/TimeTest.php b/tests/Types/TimeTest.php
@@ -15,6 +15,9 @@ protected function setUp(): void
         $this->type = new TimeType();
 
         parent::setUp();
+
+        $this->platform->method('getTimeFormatString')
+            ->willReturn('H:i:s');
     }
 
     public function testTimeConvertsToPHPValue(): void

diff --git a/tests/Types/VarDateTimeTest.php b/tests/Types/VarDateTimeTest.php
@@ -20,7 +20,7 @@ class VarDateTimeTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->platform = $this->getMockForAbstractClass(AbstractPlatform::class);
+        $this->platform = $this->createMock(AbstractPlatform::class);
         $this->type     = new VarDateTimeType();
     }