spec cumulative-buyer-time and percent-igs-cumulative-timeout #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morlovich
force-pushed
the
more-metrics4
branch
from
d26dc6f to
b175075
Compare
morlovich
changed the title
* Reserved.once specification. * Some metrics stuff, but it's a bit off for re-run, so need to think some more. Actually implement the get. * Fix handwaveyness of fetch metrics. * Fix the re-run thing, and a bit of prep for later. * Fix formatting. * Fix bug + misc found in feedback. * Typo fix. * Wire timeout from most script helpers. * Start on actual computation. * k-anon only. The impl gets it wrong. * generateBid computation. * report* * And add the base value itself. * Fix participating IG count computation. * Back to always. * Fix the reportAdditionalWin case. * Improve report-win enum at suggestion. * Fix edit mishap * Spec various P.Agg. storage usage base values. * Woops, forgot some descriptions. * Apply feedback * Apply feedback * + PA contributions type * More feedback * More phrasing tweaks. * More add -> increment * Some feedback * Fix the error case Qingxin pointed out. * Explain 110% * Fix the parse error case Qingxin pointed out, lack of timeout on top-level run is orthogonal. * Fix the lack of timeout on ScriptExecution. * More feedback * Switchify * FIx weird wrap. --------- Co-authored-by: Maks Orlovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and also describe that the final generateBid execution interrupted by cumulative timeout has no effect.