Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #190

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[StepSecurity] Apply security best practices #190

merged 1 commit into from
Mar 4, 2024

Conversation

bingenito
Copy link
Member

@bingenito bingenito commented Mar 4, 2024

Summary

This pull request is created by StepSecurity at the request of @bingenito. Please merge the Pull Request to incorporate the requested changes. Please tag @bingenito on your message if you have any questions related to the PR.

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Pinned Dependencies

GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Detect Vulnerabilities with SAST Workflow

Feedback

For bug reports, feature requests, and general feedback; please email [email protected]. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

@bingenito bingenito requested a review from a team as a code owner March 4, 2024 18:07
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.35%. Comparing base (a4dd591) to head (d9f4ae1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          16       16           
  Lines         481      481           
  Branches       59       59           
=======================================
  Hits          425      425           
  Misses         53       53           
  Partials        3        3           
Flag Coverage Δ
unittests 87.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bingenito bingenito marked this pull request as draft March 4, 2024 18:10
@bingenito bingenito force-pushed the scorecard branch 8 times, most recently from 058e382 to f69b51c Compare March 4, 2024 18:56
@bingenito bingenito marked this pull request as ready for review March 4, 2024 19:08
@psmulovics psmulovics merged commit 26dfb4c into main Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants