micro performance optimization #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should have been eliminated by hotspot and make no practical difference, actually -- I am a bit surprised it increases performance. But I like the patch nonetheless. |
|
Just to be clear, I didn't actually measure if there's any improvement, I just found this by looking at the code and thought it cannot do any harm. |
|
Oh, ok. Thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
areEqual()runscontainsKey()and thenget(), I think it's faster by runningget()directly? I found thatareEqualtakes 7% of all the CPU usage on languagetool.org, so any optimization there is welcome.