improve run-on suggestions for camel case words #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will generate some (a lot?) false-positives. Like "aloft" could be "a loft" but can also be "aloft". |
|
I've reverted this, temporarily. See @milekpl 's comment |
|
I can see a comment by @milekpl on my mail, but not online. What is the problem? |
|
I've no idea - I have the same thing! |
|
Oh, I did remove my comment because it was false! :) I added the junit test cases. I wrote my comments before running the test cases and saw that they worked, so I deleted it immediately. Sorry! |
|
Should I merge it in then? |
|
Sure. Please merge. Note that test cases will fail without the merge as well. |
|
Done! I'll try to prepare a release over the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.