feat(newsletter): Remove obsolete welcome email option

campaignion_newsletters/campaignion_newsletters.module

@@ -101,7 +101,6 @@ function campaignion_webform_component_defaults_alter(&$component, $type) {
   $component['extra'] += [
     'lists' => [],
     'opt_in_implied' => 1,
-    'send_welcome' => 0,
     'optout_all_lists' => TRUE,
   ];
 }
@@ -155,22 +154,6 @@ function campaignion_newsletters_form_webform_component_edit_form_alter(&$elemen
     '#parents' => ['extra', 'opt_in_implied'],
   ];
 
-  $element['list_management']['welcome'] = [
-    '#type' => 'container',
-    '#attributes' => ['class' => ['form-item']],
-  ];
-  $element['list_management']['welcome']['label'] = [
-    '#theme' => 'form_element_label',
-    '#title' => t('Welcome email'),
-    '#title_display' => 'before',
-  ];
-  $element['list_management']['welcome']['enabled'] = [
-    '#type' => 'checkbox',
-    '#title' => t('Send a welcome email (for new subscribers).'),
-    '#default_value' => !empty($component['extra']['send_welcome']),
-    '#parents' => ['extra', 'send_welcome'],
-  ];
-
   $element['behavior']['optout_all_lists'] = [
     '#type' => 'checkbox',
     '#title' => t('If the email address is unsubscribed it will be unsubscribed from all email lists.'),

campaignion_newsletters/src/QueueItem.php

@@ -222,13 +222,6 @@ public function optIn() {
     return !empty($this->args['send_optin']);
   }
 
-  /**
-   * Check whether a welcome email should besent.
-   */
-  public function welcome() {
-    return !empty($this->args['send_welcome']);
-  }
-
   /**
    * Trigger the queued action on the list’s provider.
    *

campaignion_newsletters/src/Subscription.php

@@ -197,10 +197,8 @@ public function delete($from_provider = FALSE) {
    * Calculate the arguments for a queue item.
    */
   public function queueItemArgs() {
-    $args['send_welcome'] = FALSE;
     $args['send_optin'] = FALSE;
     foreach ($this->components as $component) {
-      $args['send_welcome'] = $args['send_welcome'] || !empty($component['extra']['send_welcome']);
       $args['send_optin'] = $args['send_optin'] || empty($component['extra']['opt_in_implied']);
     }
     return $args;

campaignion_newsletters/tests/SubscriptionTest.php

@@ -111,8 +111,8 @@ public function testOptInThenUpdate() {
    * Test merging subscriptions.
    */
   public function testMerge() {
-    $c1 = ['cid' => 1, 'extra' => ['opt_in_implied' => 1, 'send_welcome' => 1]];
-    $c2 = ['cid' => 2, 'extra' => ['opt_in_implied' => 0, 'send_welcome' => 0]];
+    $c1 = ['cid' => 1, 'extra' => ['opt_in_implied' => 1]];
+    $c2 = ['cid' => 2, 'extra' => ['opt_in_implied' => 0]];
     $email = '[email protected]';
     $s1 = Subscription::byData(1, $email, [
       'fingerprint' => 'fingerprint1',
@@ -129,7 +129,6 @@ public function testMerge() {
     $this->assertEqual($s1->fingerprint, '');
     // TRUE wins.
     $args = $s1->queueItemArgs();
-    $this->assertTrue($args['send_welcome']);
     $this->assertTrue($args['send_optin']);
   }
 }