Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fold entirely in its own terms #969

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

atifaziz
Copy link
Member

This PR implements Fold entirely in its own terms; that is, without any dependency on or composing on top of AsserCount and Index. Fold is expected to be used for short sequences (up to a maximum length of 16 elements), so this has the positive effect of avoiding extra enumerator allocations and virtual dispatches.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #969 (0a0612d) into master (777aa24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0a0612d differs from pull request most recent head 430fe45. Consider uploading reports for the commit 430fe45 to get more accurate results

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   92.59%   92.60%           
=======================================
  Files         113      113           
  Lines        3432     3436    +4     
  Branches     1049     1051    +2     
=======================================
+ Hits         3178     3182    +4     
  Misses        191      191           
  Partials       63       63           
Impacted Files Coverage Δ
MoreLinq/AssertCount.cs 96.15% <100.00%> (-0.15%) ⬇️
MoreLinq/Fold.cs 100.00% <100.00%> (ø)
MoreLinq/Fold.g.cs 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit d2df685 into morelinq:master Feb 27, 2023
@atifaziz atifaziz deleted the stand-alone-fold branch February 27, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants