Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically discover/build glob for ECLint #957

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Jan 29, 2023

The glob list for ECLint was outdated. Rather than maintaining it by hand, this PR discovers all versioned text files and dynamically builds the glob to feed to ECLint.

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #957 (49c120a) into master (0a96b51) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   92.43%   92.52%   +0.09%     
==========================================
  Files         113      113              
  Lines        3451     3440      -11     
  Branches     1025     1024       -1     
==========================================
- Hits         3190     3183       -7     
+ Misses        196      192       -4     
  Partials       65       65              
Impacted Files Coverage Δ
MoreLinq/GlobalRandom.cs 100.00% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but recommend a future change away from eclint (now archived) to dotnet format

@atifaziz
Copy link
Member Author

@viceroypenguin This has more to do with Git and other tools generally than code formatting.

@atifaziz atifaziz merged commit 47747ef into morelinq:master Jan 29, 2023
@atifaziz atifaziz deleted the dyn-eclint-glob branch January 29, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants