Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing on .NET Core 3.1 that's no longer supported #955

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

atifaziz
Copy link
Member

This PR removes testing on .NET Core 3.1 that's no longer supported since last month (December 13, 2022).

@atifaziz atifaziz self-assigned this Jan 29, 2023
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #955 (5efc2a9) into master (0a96b51) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   92.43%   92.52%   +0.09%     
==========================================
  Files         113      113              
  Lines        3451     3440      -11     
  Branches     1025     1024       -1     
==========================================
- Hits         3190     3183       -7     
+ Misses        196      192       -4     
  Partials       65       65              
Impacted Files Coverage Δ
MoreLinq/GlobalRandom.cs 100.00% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@viceroypenguin
Copy link
Contributor

Even though 3.1 is out of support, many companies are remaining on it; I would keep it in the active testing set for the time being.

@atifaziz
Copy link
Member Author

Even though 3.1 is out of support, many companies are remaining on it; I would keep it in the active testing set for the time being.

We can always revert if there is an uptick in bugs being reported (over this year) where we're causing accidental regressions. If those bug reports never come then this change helps reduce maintenance, build and test times.

@atifaziz atifaziz merged commit 53b1217 into morelinq:master Jan 29, 2023
@atifaziz atifaziz deleted the x-netcoreapp3.1 branch January 29, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants