Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce and address code style issues #944

Merged
merged 28 commits into from
Jan 24, 2023
Merged

Enforce and address code style issues #944

merged 28 commits into from
Jan 24, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Jan 24, 2023 •
edited
Loading

Code style analysis was already configured to be enforced:

MoreLINQ/Directory.Build.props

Line 7 in 9c17aae

<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

However, this PR:

  • sets up the severity such that they are truly enforced through warnings/errors,
  • addresses identified issues in the current code base, and
  • configures individual styles as needed

Many formatting inconsistencies and issue were addressed by temporarily setting the severity of the IDE0055 rule to warning before settling on suggestion (because unfortunately many IDE0055 issues trigger on code deliberately formatted for improving readability).

atifaziz added 25 commits January 21, 2023 22:13
@atifaziz
Configure & warn for code style problems
5cdfc73
@atifaziz
Fix IDE0047: Parentheses preferences
81b0e49 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048
@atifaziz
Fix IDE0057: Use range operator
781eb5d 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0057
@atifaziz
Fix IDE0044: Add readonly modifier
db217b0 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0044
@atifaziz
Fix IDE0130: Namespace does not match folder structure
3d66ef5 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0130
@atifaziz
Fix IDE0075: Simplify conditional expression
55be725 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0075
@atifaziz
Fix IDE0200: Remove unnecessary lambda expression
b0a23b4 
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0200
@atifaziz
Fix IDE0059: Remove unnecessary value assignment
d7a2a13 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0059
@atifaziz
Fix IDE0240: Remove redundant nullable directive
fdb8164 
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0240
@atifaziz
Fix IDE0210: Convert to top-level statements
82eda7c 
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0210
@atifaziz
Fix IDE0005: Remove unnecessary using directives
d9a93d6 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0005
@atifaziz
Fix IDE0004: Remove unnecessary cast
76cad93 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0004
@atifaziz
Fix IDE0007: Use 'var'
c9e4309 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0007-ide0008
@atifaziz
Fix IDE0032: Use auto-implemented property
76c14a7 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0032
@atifaziz
Fix IDE0017: Use object initializers
70a8dce 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0017
@atifaziz
Fix IDE0011: Add braces
7d06f7a 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0011
@atifaziz
Fix IDE0010: Add missing cases to switch statement
25fb7f0 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0010
@atifaziz
Fix IDE0058: Remove unnecessary expression value
49cd9a5 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0058
@atifaziz
Fix IDE0055: Formatting rule
77dfbdc 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0055
@atifaziz
Fix IDE0045: Use conditional expression for assignment
3084470 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0045
@atifaziz
Fix IDE0021: Use expression body for constructors
0da5b7e 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0021
@atifaziz
Fix IDE0021: Use expression body for methods
6756d7f 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0021
@atifaziz
Make IDE0022 a suggestion
b805c23
@atifaziz
Remove severity from rules
f023d8c
@atifaziz
Merge remote-tracking branch 'upstream/master' into code-style
0750535 
Conflicts resolved:

- MoreLinq.Test/TestExtensions.cs
- MoreLinq/CountDown.cs
@atifaziz atifaziz self-assigned this Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #944 (9324398) into master (9c17aae) will decrease coverage by 0.02%.
The diff coverage is 95.87%.

@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
- Coverage   92.41%   92.39%   -0.02%     
==========================================
  Files         112      112              
  Lines        3442     3434       -8     
  Branches     1023     1021       -2     
==========================================
- Hits         3181     3173       -8     
  Misses        199      199              
  Partials       62       62
Impacted Files Coverage Δ
MoreLinq/Delegating.cs 90.47% <ø> (ø)
MoreLinq/Lookup.cs 61.87% <ø> (ø)
MoreLinq/SequenceException.cs 25.00% <0.00%> (ø)
MoreLinq/Transpose.cs 97.05% <ø> (ø)
MoreLinq/AssertCount.cs 96.42% <90.90%> (ø)
MoreLinq/PadStart.cs 97.77% <95.00%> (ø)
MoreLinq/AggregateRight.cs 100.00% <100.00%> (ø)
MoreLinq/Backsert.cs 96.55% <100.00%> (ø)
MoreLinq/CountDown.cs 90.00% <100.00%> (ø)
MoreLinq/CountMethods.cs 100.00% <100.00%> (ø)
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 5b49471 into morelinq:master Jan 24, 2023
@atifaziz atifaziz deleted the code-style branch January 24, 2023 20:14
@viceroypenguin viceroypenguin mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceroypenguin viceroypenguin viceroypenguin approved these changes

Assignees

@atifaziz atifaziz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atifaziz @viceroypenguin