Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one index validation bug in ToArrayByIndex #932

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

atifaziz
Copy link
Member

This PR fixes the bug identified in issue #931.

@atifaziz atifaziz linked an issue Jan 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #932 (4cb8899) into master (18dcf2c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4cb8899 differs from pull request most recent head 312b746. Consider uploading reports for the commit 312b746 to get more accurate results

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         112      112           
  Lines        3426     3426           
  Branches     1017     1017           
=======================================
  Hits         3166     3166           
  Misses        199      199           
  Partials       61       61           
Impacted Files Coverage Δ
MoreLinq/ToArrayByIndex.cs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 728bca9 into morelinq:master Jan 17, 2023
@atifaziz atifaziz deleted the fix/bug-931 branch January 17, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToArrayByIndex invokes callback when index equals array length
2 participants