Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tests for TagFirstLast #928

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Additional tests for TagFirstLast #928

merged 4 commits into from
Jan 17, 2023

Conversation

Orace
Copy link
Contributor

@Orace Orace commented Jan 16, 2023 •
edited
Loading

Add

@Orace Orace mentioned this pull request Jan 16, 2023
Merged
@Orace Orace force-pushed the TagFirstLastTest branch 3 times, most recently from f5ffb04 to b892bce Compare January 16, 2023 11:36
@Orace Orace changed the title Add TagFirstLastEvaluatesSourceLazily test Add tests for TagFirstLast Jan 16, 2023
viceroypenguin
viceroypenguin suggested changes Jan 16, 2023
View reviewed changes
MoreLinq.Test/TagFirstLastTest.cs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #928 (f2ccc37) into master (f4806f5) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head f2ccc37 differs from pull request most recent head 3b5f376. Consider uploading reports for the commit 3b5f376 to get more accurate results

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   92.39%   92.41%   +0.01%     
==========================================
  Files         112      112              
  Lines        3421     3426       +5     
  Branches     1017     1017              
==========================================
+ Hits         3161     3166       +5     
  Misses        199      199              
  Partials       61       61
Impacted Files Coverage Δ
MoreLinq/Fold.cs 97.87% <0.00%> (ø)
MoreLinq/From.cs 88.00% <0.00%> (ø)
MoreLinq/MaxBy.cs 93.39% <0.00%> (ø)
MoreLinq/Random.cs 91.89% <0.00%> (ø)
MoreLinq/Repeat.cs 100.00% <0.00%> (ø)
MoreLinq/EmptyArray.cs 100.00% <0.00%> (ø)
MoreLinq/GlobalRandom.cs 66.66% <0.00%> (ø)
MoreLinq/RandomSubset.cs 100.00% <0.00%> (ø)
MoreLinq/ToArrayByIndex.cs 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz changed the title Add tests for TagFirstLast Add tests for TagFirstLast Jan 16, 2023
@atifaziz atifaziz changed the title Add tests for TagFirstLast Additional tests for TagFirstLast Jan 16, 2023
atifaziz
atifaziz requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests. Just a couple of suggestions and then we're good to merge this!

atifaziz
atifaziz approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these additional tests.

@atifaziz atifaziz merged commit 60ec000 into morelinq:master Jan 17, 2023
@Orace Orace deleted the TagFirstLastTest branch January 17, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceroypenguin viceroypenguin viceroypenguin approved these changes

@atifaziz atifaziz atifaziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Orace @atifaziz @viceroypenguin