Address to-do about consolidating testing sequence implementations #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceroypenguin
approved these changes
Jan 15, 2023
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 112 112
Lines 3440 3440
Branches 1019 1019
=======================================
Hits 3180 3180
Misses 199 199
Partials 61 61 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a to-do comment by removing
DisposalTrackingSequenceinMemoizeTestand usingTestingSequenceinstead. This required enhancingTestingSequencewith an option to allow re-iteration of a sequence as well as exposing a property to assert if the enumerator was disposed.