Enable nullable context for entire solution #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceroypenguin
approved these changes
Dec 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 112 112
Lines 3444 3444
Branches 1021 1021
=======================================
Hits 3182 3182
Misses 200 200
Partials 62 62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atifaziz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the nullable context for the entire solution by addressing all warnings that appeared in test projects. It remove individual
#nullable enabledirectives in files. The nullable context is now enabled on all projects viaDirectory.Build.props.This PR also revises
SequenceReader<>to be sealed (YAGNI) and simpler in implementation, and as a result, making it easier to address nullability warnings. ABreakExceptionis introduced that is thrown bySequenceReader<>to avoid it being masked byInvalidOperationExceptionthat's also common in methods under test.Pending:
NullArgumentTest