Fix nullability of ToDataTable
expressions argument
#914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the nullability of
ToDataTable
expressions argument, adding to #803. The actual and possibly boxed return type of each expression (object
) is not really used; the actual type of the accessed property is. As a result, there is no requirement that the property type not be nullable and in fact can be limiting. This PR allows expressions to returnobject?
.Suppose the following record:
Before this PR, the following will issue a nullability warning (CS8603) at the line marked with the comment:
After this PR, the warning disappears.