Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullability for ZipLongest #900

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Fix nullability for ZipLongest #900

merged 2 commits into from
Dec 17, 2022

Conversation

viceroypenguin
Copy link
Contributor

This PR is for #803. Only .ZipLongest() needs nullability changes.

Issues in .ZipImpl() are not compatible between EquiZip/ZipShortest and ZipLongest (since shortest/equal do not offer null items to resultSelector, while longest does). This method will be replaced with #883 line of PRs.

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


PS I revert changes unrelated to ZipLongest and which can be committed separately.

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #900 (c62b0e2) into master (9ef27ea) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   92.38%   92.39%           
=======================================
  Files         110      112    +2     
  Lines        3442     3444    +2     
  Branches     1021     1021           
=======================================
+ Hits         3180     3182    +2     
  Misses        200      200           
  Partials       62       62           
Impacted Files Coverage Δ
MoreLinq/ZipLongest.cs 80.95% <ø> (ø)
MoreLinq/EquiZip.cs 95.91% <0.00%> (ø)
MoreLinq/ZipShortest.cs 83.33% <0.00%> (ø)
MoreLinq/IdFn.cs 100.00% <0.00%> (ø)
MoreLinq/GlobalRandom.cs 66.66% <0.00%> (ø)
MoreLinq/Random.cs 91.89% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 625ee56 into morelinq:master Dec 17, 2022
@viceroypenguin viceroypenguin deleted the zip-null branch January 17, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants