Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure Batch does not reuse internal array #820

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Add test to ensure Batch does not reuse internal array #820

merged 3 commits into from
Jun 16, 2021

Conversation

leandromoh
Copy link
Collaborator

@leandromoh leandromoh commented Jun 13, 2021 •
edited
Loading

add test to ensure that if someone try to reuse the internal array in batch (break change) the unit test will not pass

@leandromoh leandromoh force-pushed the batch/new-test branch 2 times, most recently from 3e93db9 to 2977c3b Compare June 13, 2021 00:37
@leandromoh leandromoh changed the title Add missing test for Batch Add test to ensure Batch does not reuse internal array Jun 13, 2021
@leandromoh leandromoh requested review from atifaziz and fsateler and removed request for atifaziz June 13, 2021 01:37
fsateler
fsateler approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@fsateler fsateler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps the name of the test could be a bit more explanatory, but I couldn't come up with a better one, so I'm marking as approved.

atifaziz
atifaziz approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atifaziz atifaziz merged commit cae4bcc into morelinq:master Jun 16, 2021
@leandromoh leandromoh deleted the batch/new-test branch June 17, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsateler fsateler fsateler approved these changes

@atifaziz atifaziz atifaziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leandromoh @atifaziz @fsateler