Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate test runs on Windows #769

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

atifaziz
Copy link
Member

This PR fixes test.cmd that was running same test configuration several times since the framework-specific flag was missing.

@atifaziz
Copy link
Member Author

For example, just a test run for netcoreapp2.1 (Debug) would also test the netcoreapp3.1 target:

Testing netcoreapp2.1 (Debug)...
Test run for C:\projects\morelinq\MoreLinq.Test\bin\Debug\netcoreapp3.1\MoreLinq.Test.dll (.NETCoreApp,Version=v3.1)
Microsoft (R) Test Execution Command Line Tool Version 16.8.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Skipped MemoizeIsThreadSafe [< 1 ms]
  Skipped PartialSortByIsStable [< 1 ms]
  Skipped PartialSortByIsStable [< 1 ms]
  Skipped TestRandomSubsetIsUnbiased [< 1 ms]
Passed!  - Failed:     0, Passed:  2200, Skipped:     2, Total:  2202, Duration: 3 s - MoreLinq.Test.dll (netcoreapp3.1)
Calculating coverage result...
  Generating report 'C:\projects\morelinq\MoreLinq.Test\coverage.netcoreapp3.1.opencover.xml'
+--------+------+--------+--------+
| Module | Line | Branch | Method |
+--------+------+--------+--------+
+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | NaN% | NaN%   | NaN%   |
+---------+------+--------+--------+
Test run for C:\projects\morelinq\MoreLinq.Test\bin\Debug\netcoreapp2.1\MoreLinq.Test.dll (.NETCoreApp,Version=v2.1)
Microsoft (R) Test Execution Command Line Tool Version 16.8.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Skipped MemoizeIsThreadSafe [1 ms]
  Skipped PartialSortByIsStable
  Skipped PartialSortByIsStable
  Skipped TestRandomSubsetIsUnbiased
Passed!  - Failed:     0, Passed:  2200, Skipped:     2, Total:  2202, Duration: 3 s - MoreLinq.Test.dll (netcoreapp2.1)
Calculating coverage result...
  Generating report 'C:\projects\morelinq\MoreLinq.Test\coverage.netcoreapp2.1.opencover.xml'
+--------+------+--------+--------+
| Module | Line | Branch | Method |
+--------+------+--------+--------+
+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | NaN% | NaN%   | NaN%   |
+---------+------+--------+--------+
Test run for C:\projects\morelinq\MoreLinq.Test\bin\Debug\net451\MoreLinq.Test.exe (.NETFramework,Version=v4.5.1)
Microsoft (R) Test Execution Command Line Tool Version 16.8.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Skipped MemoizeIsThreadSafe [1 ms]
  Skipped PartialSortByIsStable
  Skipped PartialSortByIsStable
  Skipped TestRandomSubsetIsUnbiased
Passed!  - Failed:     0, Passed:  2200, Skipped:     2, Total:  2202, Duration: 6 s - MoreLinq.Test.exe (net451)
Calculating coverage result...
  Generating report 'C:\projects\morelinq\MoreLinq.Test\coverage.net451.opencover.xml'
+--------+------+--------+--------+
| Module | Line | Branch | Method |
+--------+------+--------+--------+
+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | NaN% | NaN%   | NaN%   |
+---------+------+--------+--------+

This would then repeat when the intention was to test other targets individually.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #769 (31d6709) into master (9dd2d5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #769   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         108      108           
  Lines        3473     3473           
  Branches      984      984           
=======================================
  Hits         3053     3053           
  Misses        272      272           
  Partials      148      148           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd2d5e...31d6709. Read the comment docs.

@atifaziz atifaziz merged commit 31d6709 into morelinq:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant