Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Interleave tests #728

Merged
merged 36 commits into from
Jan 14, 2023
Merged

Add more Interleave tests #728

merged 36 commits into from
Jan 14, 2023

Conversation

Orace
Copy link
Contributor

@Orace Orace commented Dec 12, 2019 •
edited by atifaziz
Loading

Added:

  • TestInterleaveEarlyThrowOnNullElementInOtherSequences
  • TestInterleaveDisposesOnPartialEnumeration

Orace and others added 19 commits November 14, 2019 09:00
@Orace
Add TestInterleaveDoNoCallMoveNextEagerly.
c9aa710 
And it does.
@Orace
Fix interleave implementation so it doen't call MoveNext eagerly.
66d1228
@Orace
Update MoreLinq/Interleave.cs
336423a 
Remove useless extension method signature on a private method
@atifaziz
Fix the test
61e4921
@atifaziz
Undo implementation to prove test isn't bokren
b790e53
@atifaziz
Merge branch 'master' into issue694
c569479
@Orace @atifaziz
Add TestInterleaveDoNoCallMoveNextEagerly.
32f02e4 
And it does.
@Orace @atifaziz
Fix interleave implementation so it doen't call MoveNext eagerly.
6ff6d03
@atifaziz
Merge back originally proposed fix and test
8a972a9
@Orace
Interleave: add early test of null elements in otherSequences
1a4270f
@Orace
Added TestInterleaveEarlyThrowOnNullElementInOtherSequences
76e3516
@Orace
Remove useless private extension method
6f61760
@Orace
Added TestInterleaveDisposesOnPartialEnumeration
81479fb
@Orace
Made TestInterleaveDisposesOnPartialEnumeration pass
00ef366
@Orace
Interleave: simple implementation using Acquire.
d70974b
@Orace
remove trailing whitespaces
9be11ad
@Orace
Merge branch 'issue694' into ImproveInterleave
08f7d20
@Orace
Add TestInterleaveEarlyThrowOnNullElementInOtherSequences
77c0deb
@Orace
Add TestInterleaveDisposesAllIteratorsOnPartialEnumeration
aa942b6
@Orace Orace mentioned this pull request Dec 12, 2019
Merged
@Orace Orace changed the title Interleave: Add test on arguments check Interleave: Add tests Dec 12, 2019
atifaziz
atifaziz requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a conflict resolution since merge of PR #696.

@Orace Orace requested a review from atifaziz December 12, 2019 11:07
@Orace
Rename TestInterleaveDisposesOnError to TestInterleaveDisposesOnError…
8164514 
…AtGetEnumerator

Add TestInterleaveDisposesOnErrorAtMoveNext
@codecov
Copy link

codecov bot commented Dec 12, 2019 •
edited
Loading

Codecov Report

Merging #728 (a51be99) into master (4c583f2) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   92.41%   92.44%   +0.02%     
==========================================
  Files         112      112              
  Lines        3440     3440              
  Branches     1018     1018              
==========================================
+ Hits         3179     3180       +1     
+ Misses        200      199       -1     
  Partials       61       61
Impacted Files Coverage Δ
MoreLinq/Interleave.cs 100.00% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Orace
Copy link
Contributor Author

Orace commented Dec 12, 2019 •
edited
Loading

Those tests are useful to correctly fix #729 that is addressed in #730.

atifaziz
atifaziz approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry to have taken so long to get back on this.

@atifaziz atifaziz mentioned this pull request Jan 14, 2023
Closed
@atifaziz atifaziz changed the title Interleave: Add tests Add more Interleave tests Jan 14, 2023
@atifaziz
Merge remote-tracking branch 'origin/Interleave/add-tests' into Imrpo…
dfa9467 
…veInterleaveTests

Conflicts resolved:

- MoreLinq.Test/InterleaveTest.cs
@atifaziz atifaziz force-pushed the ImrpoveInterleaveTests branch from 739850c to dfa9467 Compare January 14, 2023 15:32
@atifaziz atifaziz merged commit 34c7ebe into morelinq:master Jan 14, 2023
@Orace Orace deleted the ImrpoveInterleaveTests branch January 16, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atifaziz atifaziz atifaziz approved these changes

Assignees
No one assigned
Labels
Component-Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orace @atifaziz