Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude: Add test, fix implementation #669

Closed
wants to merge 2 commits into from
Closed

Exclude: Add test, fix implementation #669

wants to merge 2 commits into from

Conversation

Orace
Copy link
Contributor

@Orace Orace commented Nov 8, 2019

Fix a part of #649
Fork of #660

Orace added 2 commits November 8, 2019 20:15
@Orace
Add TestExcludeOnKnownInput
3f42ffb
@Orace
Fix Exclude implementation
264bc88 
Avoid calls to MoveNext after enumerator end.
atifaziz
atifaziz requested changes Nov 9, 2019
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are far too many edits in this PR that don't seem related to #649. Please revise to focus on just the one problem identified in #649.

@Orace
Copy link
Contributor Author

Orace commented Nov 9, 2019

For the headers, I opened #671

@Orace
Copy link
Contributor Author

Orace commented Nov 9, 2019 •
edited
Loading

Closed. The missing using statement is fixed here #673

@Orace Orace closed this Nov 9, 2019
@Orace
Copy link
Contributor Author

Orace commented Nov 12, 2019

Exclude call to MoveNext after sequence end is fixed here #692

@atifaziz
Copy link
Member

Thank you for the splits!

@Orace
Copy link
Contributor Author

Orace commented Nov 12, 2019

You are welcome.

@Orace Orace deleted the Exclude branch November 20, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atifaziz atifaziz atifaziz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orace @atifaziz