Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Subsets core into an iterator method #1052

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Nov 21, 2023

This PR refactors the implementation of Subsets into a simpler iterator method. As a by-product, it:

@atifaziz atifaziz changed the title Refactor "Subsets" core into an iterator method Refactor Subsets core into an iterator method Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a263661) 92.52% compared to head (2a72577) 92.49%.

Files Patch % Lines
MoreLinq/Subsets.cs 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   92.52%   92.49%   -0.04%     
==========================================
  Files         113      113              
  Lines        3413     3385      -28     
  Branches     1058     1057       -1     
==========================================
- Hits         3158     3131      -27     
+ Misses        189      187       -2     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atifaziz atifaziz merged commit 2a72577 into morelinq:master Nov 22, 2023
3 of 4 checks passed
@atifaziz atifaziz deleted the refactor-subsets branch November 22, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsets enumerator doesn't return same array from Current
1 participant