Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception thrown when Pad/PadStart width is invalid #1030

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

atifaziz
Copy link
Member

This PR fixes #1027 and #1028.

@atifaziz atifaziz changed the title Fix exception thrown for invalid Pad/PadStart width Fix exception thrown when Pad/PadStart width is invalid Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1030 (17f3df5) into master (2c3f004) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 17f3df5 differs from pull request most recent head 299c2c9. Consider uploading reports for the commit 299c2c9 to get more accurate results

@@           Coverage Diff           @@
##           master    #1030   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files         113      113           
  Lines        3421     3421           
  Branches     1056     1056           
=======================================
  Hits         3169     3169           
  Misses        189      189           
  Partials       63       63           
Files Coverage Δ
MoreLinq/Pad.cs 100.00% <100.00%> (ø)
MoreLinq/PadStart.cs 97.91% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 092a40d into morelinq:master Oct 28, 2023
@atifaziz atifaziz deleted the fix/pad-width-err-type branch October 28, 2023 14:55
julienasp pushed a commit to julienasp/MoreLINQ that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pad should throw ArgumentOutOfRangeException for invalid width
1 participant