Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema binding signature in ToDataTable implementation #1008

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

atifaziz
Copy link
Member

This PR fixes the nullable annotations on signatures of internal methods that make up the ToDataTable implementation, such as BuildOrBindSchema and CreateShredder.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1008 (feccd25) into master (f59f7a5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head feccd25 differs from pull request most recent head d739f65. Consider uploading reports for the commit d739f65 to get more accurate results

@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files         113      113           
  Lines        3422     3422           
  Branches     1055     1055           
=======================================
  Hits         3097     3097           
  Misses        263      263           
  Partials       62       62           
Impacted Files Coverage Δ
MoreLinq/ToDataTable.cs 96.51% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit d739f65 into morelinq:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant