Dissolve schema query into distinct ToDataTable
paths
#1007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR that improves
ToDataTable
.The internal
BuildOrBindSchema
method created a schema projection (schemas
), but the two paths taken by the code (based on whether the table had columns) accessed distinct parts of the projection. This PR removes the query to save on allocation costs, moves the only shared bit into a new local function calledGetElementaryTypeOfPropertyOrField
and the rest is dissolved into each code path.