Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interleave shouldn't validate otherSequences members #1029

Closed
atifaziz opened this issue Oct 28, 2023 · 0 comments · Fixed by #1031
Closed

Interleave shouldn't validate otherSequences members #1029

atifaziz opened this issue Oct 28, 2023 · 0 comments · Fixed by #1031
Assignees
@atifaziz
Labels
breaking-change
Milestone
4.0.0

Comments

@atifaziz
Copy link
Member

Interleave validates that elements/members of the otherSequences are non-null and throws ArgumentNullException claiming that otherSequences is null. It isn't common to validate contents for a sequence argument and so a null element in otherSequences should be left as an undefined behaviour.
@atifaziz atifaziz added this to the 4.0 milestone Oct 28, 2023
@atifaziz atifaziz self-assigned this Oct 28, 2023
@atifaziz atifaziz mentioned this issue Oct 28, 2023
Merged
atifaziz added a commit that referenced this issue Oct 28, 2023
@atifaziz
Don't validate content of "Interleave" arg
0209897 
This is a squashed merge of PR #1031 that fixes #1029.
@atifaziz atifaziz mentioned this issue Oct 28, 2023
Closed
julienasp pushed a commit to julienasp/MoreLINQ that referenced this issue Nov 14, 2023
@atifaziz @julienasp
Don't validate content of "Interleave" arg
96f53b4 
This is a squashed merge of PR morelinq#1031 that fixes morelinq#1029.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atifaziz atifaziz

Labels
breaking-change
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Don't validate content of otherSequences argument of Interleave atifaziz/MoreLINQ
1 participant
@atifaziz