Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Notifcation: Couldn't update workflow #128

Open
Code-Remote opened this issue Jan 2, 2020 · 24 comments
Open

Notifcation: Couldn't update workflow #128

Code-Remote opened this issue Jan 2, 2020 · 24 comments
Milestone
v6.0.0

Comments

@Code-Remote
Copy link

Description

  1. I got a notification that there was a new update for this workflow available
  2. Downloaded the update via Alfred
  3. When I use the keyword to create a new task and enter the first letter I get a notifcation from Alfred saying

"ALFRED WORKFLOW TODOIST
Couldn't update workflow
Cannot read property 'length' of null"

  1. When I continue typing and press enter, the task is still created properly. But for each word I type I a get a new notification, sometimes even stack on top of each other and Alfred just shows

"Alfred 4
8x notifications"

  1. I tried to reinstall it again, delete workflow from Alfred 4 and go to github download it again. But then I saw that the version was still 5.8.3 and not 5.8.4

Steps to reproduce

Steps to reproduce the behavior:

  1. Install the new version of Todoist workflow
  2. Use keyword 'todo' and enter any letter
  3. See error

Expected behavior

Don't show this notification with the error

Log:

[21:56:21.852] Alfred Workflow Todoist[Script Filter] Queuing argument 'test'
[21:56:22.887] Alfred Workflow Todoist[Script Filter] Script with argv '(null)' finished
[21:56:22.889] Alfred Workflow Todoist[Script Filter] {"items":[{"uid":"693e9af84d3dfcc71e640e005bdc5e2e","title":"CREATE: test","subtitle":"INBOX","icon":{"path":"icon.png"},"arg":"{\"content\":\"test\",\"priority\":1}","type":"default","valid":true}]}

ALFRED WORKFLOW TODOIST
----------------------------------------
os: 10.15.2 (19C57)
query: "todo test"
node.js: v12.10.0
alfred: 4.07
workflow: 3.8.3
 ...
@moranje
Copy link
Owner

moranje commented Jan 3, 2020

Thanks for letting me know. I am currently working on a big update which fixes a lot of the outstanding issues. The problem you are running into is just with the updater. You can still update by downloading the workforce from github.

Martien

@stacksjb
Copy link

stacksjb commented Jan 6, 2020

I am having this problem as well - it appears something is wrong with Github, as downloading the link for the latest version (https://github.com/moranje/alfred-workflow-todoist/releases/latest/download/Alfred.Workflow.Todoist.alfredworkflow) and/or the link at https://github.com/moranje/alfred-workflow-todoist/releases/tag/v5.8.4 is currently giving me a version 5.8.3 file when it is actually downloaded.

Downloading the beta version from Issue #125 (https://github.com/moranje/alfred-workflow-todoist/files/3902539/Alfred.Workflow.Todoist.zip) doesn't have the issue.

@moranje
Copy link
Owner

moranje commented Jan 6, 2020

Hmm that's not good, I need to sleep right now. I'll have a look tomorrow. Thanks for the feedback

Martien

@smagdali
Copy link

smagdali commented Jan 9, 2020

This just happened to me as well. I got a notification that 5.8.4 was available, went to download it, tried to install it, and now am getting the exact same error as OP. As per stacksjb, Installed workflow claims to be 5.8.3 not 5.8.4

@smagdali
Copy link

smagdali commented Jan 9, 2020

This just happened to me as well. I got a notification that 5.8.4 was available, went to download it, tried to install it, and now am getting the exact same error as OP. As per stacksjb, Installed workflow claims to be 5.8.3 not 5.8.4

Can confirm that the version in #125 works fine.

@jakubka
Copy link

jakubka commented Jan 18, 2020

Getting the same thing after installing the workflow for the first time.

Just guessing, but shouldn't we have "version": "5.8.4" here https://github.com/moranje/alfred-workflow-todoist/blob/master/dist/workflow/workflow.json#L2 ?

The 5.8.4 release has already been done, so a new corrected 5.8.5 will need to be made?

I can submit a PR if you confirm that this is indeed an issue @moranje

@moranje
Copy link
Owner

moranje commented Jan 20, 2020

No the workflow.json is whats used to check for updates against. The process of updating the version in the workflow (.plist) and in the package json is automated.

I would like to release a major version update soon. I'm currently little preoccupied with my newborn son. I'll post something as soon as I'm able.

Martien

@moranje moranje added this to the v6.0.0 milestone Feb 4, 2020
moranje added a commit that referenced this issue Feb 5, 2020
@moranje
feat(project): full rewrite
2849c8a 
Improve string parsing, now requires id for project, labels and sections(BREAKING)
Searching of
tasks by section and setting of sections to tasks now possible
Fix update error #128 (bug)
Set time
to next update check (settings)
Optionally receive pre-releases of this workflow
Show task title in
notification when created #126
Set cache timeout for tasks
Allow filtering tasks by project, label,
priority and section #20
Improved error handling and feedback, easily fill out a bug report when an
unexpected error is encountered
Show more helpful errors when a call to the Todoist API fails
#124
Improved typing and code documentation for contributors

BREAKING CHANGE:
Improve string parsing, now requires id for project, labels and sections

ISSUES CLOSED: #128 #126 #124 #20
moranje pushed a commit that referenced this issue Feb 8, 2020
@semantic-release-bot
chore(release): 6.0.0-alpha.1 [skip ci]
e51cfda 
# [6.0.0-alpha.1](v5.8.4...v6.0.0-alpha.1) (2020-02-08)

### Features

* **project:** full rewrite ([2849c8a](2849c8a)), closes [#128](#128) [#126](#126) [#20](#20) [#124](#124) [#128](#128) [#126](#126) [#124](#124) [#20](#20)
* **project:** provide a useful error as a list item when node.js is not installed ([e039157](e039157))

### BREAKING CHANGES

* **project:** Improve string parsing, now requires id for project, labels and sections
@moranje
Copy link
Owner

moranje commented Feb 8, 2020 •
edited
Loading

Should be fixed in the v6.0.0-alpha.3. It should be stable enough to use as your daily driver, I now have tests for 80% of the code base.

If you want to keep receiving updates set todo:setting pre_releases true. I still need to update the docs so not all the changes are documented yet.

Martien

@augustgerro
Copy link

Same error. Downloaded by link in Readme

todo:settings pre_releases true
NO SUCH SETTING

@stacksjb
Copy link

stacksjb commented Feb 9, 2020

For me the setting is "todo:settingpre_releases"

@moranje
Copy link
Owner

moranje commented Feb 9, 2020

@augustgerro the link for the alpha is here.

And @stacksjb is right the setting is a todo:setting pre_releases true (minus the additional s0

@moranje
Copy link
Owner

moranje commented Feb 11, 2020

Heads-up: 6.0.0-alpha.4 is out which fixes two nasty bugs, the updater not picking new prereleases and a very unhelpful blocking error message when the API token hasn't been set yet.

Cheers

@stacksjb
Copy link

@augustgerro the link for the alpha is here.

And @stacksjb is right the setting is a todo:setting pre_releases true (minus the additional s0

You mean additional space?

Screen Shot 2020-02-11 at 7 43 23 PM

@stacksjb
Copy link

One other thing I've noticed with this release - it appears you've added some sort of unique identifier to the labels and tags, and the first entry says "refresh cache" - is this permanent/intended to stay or just there as part of the pre/debug releases? Slows down my workflow a bit because I typically hit tab and keep typing, but now I have to arrow down and hit enter on the entry specifically.

Screen Shot 2020-02-11 at 7 49 49 PM

@moranje
Copy link
Owner

moranje commented Feb 12, 2020

@stacksjb Thanks for reporting back. I agree that the refresh cache shouldn't be the first item. I rely on Alfreds sorting items to most used but doesn't make a whole lot of sense. I fix that in the next alpha. I'll open a new issue when I get around to it.

The id's you see are Todoists ids for that resource. I need it to for the API calls. It's a little ugly but the code I relied on made the workflow a little slower and is error prone. This way the ids are validated by the end user. I figured that in this case functionality over beauty...

Keep any observations coming. I've also integrated an easy way to report bugs into the workflow if you run into any.

Cheers, Martien

@moranje moranje mentioned this issue Feb 12, 2020
Closed
@moranje moranje changed the title Notifcation: Couldn't update workflow, Cannot read property 'length' of null Notifcation: Couldn't update workflow Feb 16, 2020
github-actions bot pushed a commit that referenced this issue Feb 26, 2020
@semantic-release-bot
chore(release): 6.0.0-beta.1 [skip ci]
27855a4 
# [6.0.0-beta.1](v5.8.4...v6.0.0-beta.1) (2020-02-26)

### Bug Fixes

* **settings:** rename annonymous_statistics to error_tracking ([3816345](3816345))
* api filter requests being broken ([3b344a1](3b344a1))
* **build:** possibly fix version number not updated in alfred workflow ([ac02c22](ac02c22))
* **cache:** cache always being reset ([d83408e](d83408e))
* **cache:** handle empty resource lists ([af89785](af89785))
* **cache:** issue where cache timestamps wouldn't be updated once created ([5156040](5156040))
* **commands:** [#151](#151) don't rely on alfred input filtering, remove uids ([92d9ac4](92d9ac4))
* **commands:** certain characters not (" and \) being parsed ([d53d68f](d53d68f))
* **commands:** error when trying to retrieve a non existent project ([42e0009](42e0009))
* **project:** unhelpful error message when missing todoist token in settings ([5a0af91](5a0af91))
* **settings:** [#152](#152) settings break with multiple consecutive spaces ([b3f2f2a](b3f2f2a))
* **todoist:** task cache not being refreshed ([179c0bc](179c0bc))
* alfred workflow version is the same as the release version again ([0ce67a3](0ce67a3))
* updater not picking up new prereleases, please update manually ([fdcb793](fdcb793))
* updater not storing last update timestamp ([35ff532](35ff532))

### Features

* **commands:** [#13](#13) sort by due date by default ([32044b0](32044b0))
* **commands:** filter tasks directly through Todoist ([f9bd460](f9bd460)), closes [#13](#13) [#20](#20) [#72](#72)
* **parser:** reimplement date from now for timestamped tasks ([cd090d8](cd090d8))
* **project:** full rewrite ([2849c8a](2849c8a)), closes [#128](#128) [#126](#126) [#20](#20) [#124](#124) [#128](#128) [#126](#126) [#124](#124) [#20](#20)
* **project:** provide a useful error as a list item when node.js is not installed ([e039157](e039157))

### BREAKING CHANGES

* **project:** Improve string parsing, now requires id for project, labels and sections
@jrosen48
Copy link

Hi all, I am also getting the "couldn't update workflow" warning.

@moranje
Copy link
Owner

moranje commented May 28, 2020

Is this with the latest beta?

@edbltn
Copy link

edbltn commented Jun 6, 2020

I just downloaded it and I'm also getting this warning

@moranje
Copy link
Owner

moranje commented Jun 7, 2020

Hi @edbltn can you confirm that this is with the latest beta?

@jrosen48
Copy link

jrosen48 commented Jun 7, 2020

Is this with the latest beta?

Sorry I missed this - this was with the version available at this link (accessed from the README):

https://github.com/moranje/alfred-workflow-todoist/releases/latest/download/Alfred.Workflow.Todoist.alfredworkflow

Is this not the latest beta? Thank you!

@JunoCopy
Copy link

Hey there. Thanks for your work on this.

Just installed and seeing the same error message. I downloaded from the main code page on GH, this is the link:
https://github.com/moranje/alfred-workflow-todoist/releases/latest/download/Alfred.Workflow.Todoist.alfredworkflow

It still seems to create tasks but always get the error first. I also see it is not searching old tasks that were not created with the workflow and when they are deleted, they still show up in the search list too.

Thanks again!

@moranje
Copy link
Owner

moranje commented Jun 15, 2020

@jrosen48 @junoCA No it's not, that's master.

The latest fairly stable release is at:

https://github.com/moranje/alfred-workflow-todoist/releases/download/v6.0.0-beta.1/Alfred.Workflow.Todoist.alfredworkflow

See if that helps.

Martien

@JunoCopy
Copy link

Awesome, thanks @moranje

Just imported and not seeing any issues i did before. Searching old tasks works too :)

thanks again!

@pat-s
Copy link

pat-s commented Jun 25, 2020

I also faced this, the v6 beta1 release seems to fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
10 participants
@moranje @smagdali @stacksjb @augustgerro @jrosen48 @jakubka @pat-s @edbltn @Code-Remote @JunoCopy