Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #569: NoSuchElementException in Session.drainQueueToConnection #570

Merged
merged 1 commit into from
May 1, 2021
Merged

Fixes #569: NoSuchElementException in Session.drainQueueToConnection #570

merged 1 commit into from
May 1, 2021

Commits on Feb 2, 2021

  1. Fixes moquette-io#569: NoSuchElementException in Session.drainQueueTo… 

    …Connection

Session.drainQueueToConnection checks sessionQueue.isEmpty(), and then
uses sessionQueue.remove(). However, between the check and the remove,
another thread can steal the last message, causing the remove() to throw
an exception. Better to use sessionQueue.poll() with a null-check.
    @hylkevds
    hylkevds committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    300e8bc View commit details
    Browse the repository at this point in the history