Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.14: InflightSlots counting not reliable #583

Closed
hylkevds opened this issue Feb 24, 2021 · 1 comment
Closed

0.14: InflightSlots counting not reliable #583

hylkevds opened this issue Feb 24, 2021 · 1 comment

Comments

@hylkevds
Copy link
Collaborator

Expected behavior

The value for inflightSlots is always between 1 and 10 (currently hard coded)

Actual behavior

The value of inflightSlots can go higher than 10

Steps to reproduce

Have a QOS message that is not acked before being re-sent, then have the client ack both versions.
inflightSlots will be increased for both acks, even though it was decreased only once.

Minimal yet complete reproducer code (or URL to code) or complete log file

None yet.

Moquette MQTT version

0.14
hylkevds added a commit to FraunhoferIOSB/moquette that referenced this issue Feb 24, 2021
@hylkevds
Fixes moquette-io#583: inflightSlots counting error
8ca9f73 
When processing an ACK, the inflightSlots should only be increased if it
is the first time the ACK is received for a given message. The ACK may
be received multiple times, the subsequent ACKs should not cause the
count to be increased.
hylkevds added a commit to FraunhoferIOSB/moquette that referenced this issue May 9, 2021
@hylkevds
Fixes moquette-io#583: inflightSlots counting error
dd89c6b 
When processing an ACK, the inflightSlots should only be increased if it
is the first time the ACK is received for a given message. The ACK may
be received multiple times, the subsequent ACKs should not cause the
count to be increased.
hylkevds added a commit to FraunhoferIOSB/moquette that referenced this issue May 24, 2021
@hylkevds
Fixes moquette-io#583: inflightSlots counting error
038815f 
When processing an ACK, the inflightSlots should only be increased if it
is the first time the ACK is received for a given message. The ACK may
be received multiple times, the subsequent ACKs should not cause the
count to be increased.
hylkevds added a commit to FraunhoferIOSB/moquette that referenced this issue May 24, 2021
@hylkevds
Fixes moquette-io#583: inflightSlots counting error
a760659 
When processing an ACK, the inflightSlots should only be increased if it
is the first time the ACK is received for a given message. The ACK may
be received multiple times, the subsequent ACKs should not cause the
count to be increased.
@hylkevds hylkevds mentioned this issue May 24, 2021
Closed
@hylkevds
Copy link
Collaborator Author

This has been fixed in the meantime, thus closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hylkevds